ปรับปรุงรายงานแบบประเมิน และแก้ไข bug จากผล unit test

This commit is contained in:
Nakorn Rientrakrunchai
2020-08-30 11:16:09 +07:00
parent a049fa6d8b
commit 2df3962e59
10 changed files with 160 additions and 96 deletions

View File

@@ -20,14 +20,14 @@ namespace TodoAPI2.Models
public class eva_idp_plan_ownerService : Ieva_idp_plan_ownerService
{
private IBaseRepository2<eva_idp_planEntity, int> _repository;
private IMyDatabase db;
private Iexternal_linkageService ext;
private IMyDatabase db;
private Iexternal_linkageService ext;
public eva_idp_plan_ownerService(IBaseRepository2<eva_idp_planEntity, int> repository, IMyDatabase mydb, Iexternal_linkageService inext)
{
_repository = repository;
db = mydb;
ext = inext;
db = mydb;
ext = inext;
}
#region Private Functions
@@ -47,7 +47,7 @@ namespace TodoAPI2.Models
{
return Mapper.Map<List<eva_idp_plan_ownerViewModel>>(entities);
}
#endregion
#region Public Functions
@@ -77,18 +77,18 @@ namespace TodoAPI2.Models
public List<eva_idp_plan_ownerViewModel> GetListBycreate_evaluation_detail_id(int? create_evaluation_detail_id)
{
var model = new eva_idp_plan_ownerSearchModel();
var model = new eva_idp_plan_ownerSearchModel();
model.create_evaluation_detail_id = create_evaluation_detail_id;
return GetListBySearch(model);
}
public List<eva_idp_plan_ownerViewModel> GetListBySearch(eva_idp_plan_ownerSearchModel model)
public List<eva_idp_plan_ownerViewModel> GetListBySearch(eva_idp_plan_ownerSearchModel model)
{
var data = (
from m_eva_idp_plan_owner in _repository.Context.eva_idp_plan
where 1==1
where 1 == 1
//&& (m_eva_idp_plan_owner.id == model.id || !model.id.HasValue)
&& (m_eva_idp_plan_owner.create_evaluation_detail_id == model.create_evaluation_detail_id || !model.create_evaluation_detail_id.HasValue)
@@ -122,10 +122,10 @@ namespace TodoAPI2.Models
int? newkey = 0;
var x = (from i in _repository.Context.eva_idp_plan
orderby i.id descending
select i).Take(1).ToList();
orderby i.id descending
select i).Take(1).ToList();
if(x.Count > 0)
if (x.Count > 0)
{
newkey = x[0].id + 1;
}
@@ -139,9 +139,9 @@ namespace TodoAPI2.Models
entity.id = GetNewPrimaryKey();
entity.SetAutoField(_repository.Context);
var inserted = _repository.Insert(entity);
return Get(inserted.id);
}
@@ -156,30 +156,30 @@ namespace TodoAPI2.Models
existingEntity.start_date = model.start_date;
existingEntity.end_date = model.end_date;
existingEntity.SetAutoField(_repository.Context);
var updated = _repository.Update(id, existingEntity);
return Get(updated.id);
}
else
throw new NotificationException("No data to update");
throw new NotificationException("No data to update");
}
public string UpdateMultiple(List<eva_idp_plan_ownerInputModel> model)
public string UpdateMultiple(List<eva_idp_plan_ownerInputModel> model)
{
foreach(var i in model)
foreach (var i in model)
{
if (i.active_mode == "1" && i.id.HasValue) // update
{
{
var existingEntity = _repository.Get(i.id.Value);
if (existingEntity != null)
{
existingEntity.create_evaluation_detail_id = i.create_evaluation_detail_id;
existingEntity.develop = i.develop;
existingEntity.development_method = i.development_method;
existingEntity.start_date = i.start_date;
existingEntity.end_date = i.end_date;
existingEntity.create_evaluation_detail_id = i.create_evaluation_detail_id;
existingEntity.develop = i.develop;
existingEntity.development_method = i.development_method;
existingEntity.start_date = i.start_date;
existingEntity.end_date = i.end_date;
existingEntity.SetAutoField(_repository.Context);
_repository.UpdateWithoutCommit(i.id.Value, existingEntity);
}
}
@@ -187,18 +187,19 @@ namespace TodoAPI2.Models
{
var entity = GetEntity(i);
entity.id = GetNewPrimaryKey();
entity.SetAutoField(_repository.Context);
_repository.InsertWithoutCommit(entity);
}
else if (i.active_mode == "0" && i.id.HasValue) // remove
{
{
_repository.DeleteWithoutCommit(i.id.Value);
}
else if (i.active_mode == "0" && !i.id.HasValue)
{
// nothing to do
}
}
}
_repository.Context.SaveChanges();
_repository.Context.SaveChanges();
return model.Count().ToString();
}
@@ -222,7 +223,7 @@ namespace TodoAPI2.Models
return;
}
private Dictionary<string,string> GetLookupForLog()
private Dictionary<string, string> GetLookupForLog()
{
var i = new Dictionary<string, string>();
@@ -233,7 +234,7 @@ namespace TodoAPI2.Models
i.Add("start_date", "ช่วงเวลาเริ่มต้นพัฒนา");
i.Add("txt_start_date", "ช่วงเวลาเริ่มต้นพัฒนา");
i.Add("end_date", "ช่วงเวลาสิ้นสุดพัฒนา");
i.Add("txt_end_date", "ช่วงเวลาสิ้นสุดพัฒนา");
i.Add("txt_end_date", "ช่วงเวลาสิ้นสุดพัฒนา");
return i;
}
@@ -246,4 +247,5 @@ namespace TodoAPI2.Models
#endregion
}
}
}